FEPLT-2124: add X icon and deprecate Twitter icon #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-deprecate-twitter.surge.sh |
DSil
force-pushed
the
dsil/deprecate-twitter
branch
from
7aa181f to
bf08137
Compare
Deploying orbit with
|
| Latest commit: |
f37d0a1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ddd9ca4.orbit.pages.dev |
| Branch Preview URL: | https://dsil-deprecate-twitter.orbit.pages.dev |
|
Size Change: -70 B (-0.02%) Total Size: 460 kB
ℹ️ View Unchanged
|
|
I have a question related to |
RobinCsl
reviewed
Oct 3, 2024
| @@ -14,4 +14,10 @@ With this guide, we aim to walk through all the breaking changes and how they ca | |||
|
|
|||
| ### ColoredTwitter icon removed | |||
|
|
|||
| The `ColoredTwitter` icon was removed. The `Twitter` icon should be used instead. | |||
| The `ColoredTwitter` icon was removed. The `X` icon should be used instead. | |||
There was a problem hiding this comment.
Given this, I'm wondering if we should just bundle the removal with the Twitter icon too.
There was a problem hiding this comment.
I thought the same… We can… I have nothing against it. And we avoid the deprecation entirely?
There was a problem hiding this comment.
Agreed IRL that we will avoid the deprecation and just remove the icon in this release as well
RobinCsl
reviewed
Oct 3, 2024
| @@ -1,4 +1,4 @@ | |||
| <!--character:1007--> | |||
| <!--character:0007--> | |||
There was a problem hiding this comment.
Curious about this change, do you know what caused this?
There was a problem hiding this comment.
I manually changed this 🙈 we can't have repeated character ids, but they are not really "scientific". And since we were gonna remove it soon, I just changed this to an unexisting number
There was a problem hiding this comment.
Just for me to understand the relevance: how/where is this information used? :D
RobinCsl
approved these changes
Oct 3, 2024
DSil
force-pushed
the
dsil/deprecate-twitter
branch
from
0df4655 to
14b041f
Compare
BREAKING CHANGE: Twitter icon was removed. X icon should be used instead.
BREAKING CHANGE: SocialButton's type prop no longer accepts "twitter". "X" type is now accepted.
DSil
force-pushed
the
dsil/deprecate-twitter
branch
from
1faf693 to
f37d0a1
Compare
RobinCsl
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Twittericon is now deprecated and theXicon was added.